search

TPL-protocol / demo-dapp

Sample dapp for showcasing TPL
MIT License
9 stars 2 forks source link

Add the UI to view and buy tokens #6

Closed come-maiz closed 6 years ago

come-maiz commented 6 years ago

Requires #5

frangio commented 6 years ago

Are we planning to use mapDispatchToProps as was recommended in another review?

come-maiz commented 6 years ago

I did mapDispatchToProps in #8. I will try moving findAccount higher, and I reported #10 to experiment with react-web3.

come-maiz commented 6 years ago

ok, I added Account.react.js, which is now the only one who gets the account. @frangio please take a look to see if it's good enough while we get react-web3.

come-maiz commented 6 years ago

I thought about making it a parent. Just a little, not much. And it seemed to me that because we share the store everywhere, the hierarchy doesn't matter much. I will dig more when using the Web3Provider, but this makes me think that it's also not important where you put it: https://www.npmjs.com/package/react-web3#redux-support

Thanks again! I hope that getting less things to fix from you means that I'm getting the hang of this, and not that you are getting tired ;)

merging...