search

TPM-Repos / ModifiedCorporateTheme

A fork of the official Integration Theme Corporate website from DriveWorks modified for use by TPM, Inc.
https://demo.tpmautomation.com/Corporate/TPM/
MIT License
1 stars 5 forks source link

Login page carousel images are not sized (do not resize) properly #51

Closed joelhanneman closed 1 month ago

joelhanneman commented 2 months ago

Reference: https://niko.tpmautomation.com/

Images taken directly from their website, ex: https://www.nikocranes.com/products/jib-cranes/

Saved image files here: \DWLive\DWGroupContent\NIKO\Website\dist\img

joelhanneman commented 2 months ago

@jccaswell , is this something that is easily fixed? The images supplied to the website are of no particular size. Do they need to be or can the website resize them somehow?

jccaswell commented 1 month ago

The images resize to the available screen real estate in order to show no white space and not lose their aspect ratio. I do not plan on changing this behavior.

joelhanneman commented 1 month ago

To confirm, the solution is to supply images with the correct aspect ratio?

jccaswell commented 1 month ago

There is not such thing as a "correct aspect ratio" the aspect ratio of my monitor is different then yours, and different again from our phones. Also, because this is in a browser there is nothing saying that you have to have it open in full screen. Consider these examples: My laptop: image Browser not maximized: image iPad Air: image

You will notice that the aspect ratio for the space available is different for each. But, there is no white space in any case, and the image doesn't look skewed.

Let's consider if we forced the entire image to visible: Maintain aspect ratio: image Fill all space: image

These alternatives may be preferable if there was specific information we wanted to ensure was shown: but that is not the purpose of the carousel. It is simply there to look pretty and give some branding.