lds implementation - Githubissues

TRAIS-Lab / dattri

`dattri` is a PyTorch library for developing, benchmarking, and deploying efficient data attribution algorithms.

https://trais-lab.github.io/dattri/

MIT License

30 stars 9 forks source link

Closed jackhaohuang closed 6 months ago

jackhaohuang commented 6 months ago

We complete the proposal in the issue #9.

We implemented functions retrain_lds, calculate_lds_groundtruth, and lds. We also designed unit-tests for all three functions.

[ ] N/A: No test will be added (please justify)
[x] Unit test: Typically, this should be included if you implemented a new function/fixed a bug.
[ ] Application test: If you wrote an example for the toolkit, this test should be added.
[ ] Document test: If you added an external API, then you should check if the document is correctly generated.

TheaperDeng commented 6 months ago

Please update the description as the template in https://github.com/TRAIS-Lab/dattri/pull/6

jackhaohuang commented 6 months ago

Please update the description as the template in #6

We have fixed everything except for one ruff error indicating the error with unformatted problems, could you please provide some suggestions with us?

xingjian-zhang commented 6 months ago

Also, please resolve the conflicts before merging.

xingjian-zhang commented 6 months ago

Please fix according to the style checks.

jiaqima commented 6 months ago

Sorry I made a change in pytest.yml. You may need to pull and rebase your branch.

jackhaohuang commented 6 months ago

My unittest passed locally and I checked the type of my variables are tensor. I am not sure why it doesn't pass on GitHub.

TheaperDeng commented 6 months ago

I have fixed most of the issue @xingjian-zhang .

jiaqima commented 6 months ago

Closing this one in favor of #48 and #49