search

TRAIS-Lab / dattri

`dattri` is a PyTorch library for developing, benchmarking, and deploying efficient data attribution algorithms.
https://trais-lab.github.io/dattri/
MIT License
28 stars 8 forks source link

Shaky test test_ihvp_cg_nn #43

Closed jiaqima closed 4 months ago

jiaqima commented 4 months ago

The test test_ihvp_cg_nn is shaky and occasionally fails. Likely due to that atol is set to be too strict. But in case it was due to an implementation issue of ihvp_cg, @TheaperDeng could you take a look?

See this test result for an example failure: https://github.com/TRAIS-Lab/dattri/actions/runs/8827208022/job/24234114891

TheaperDeng commented 4 months ago

I guess this is caused by a strict atol. Let me relax the tol and monitor it for a while.

TheaperDeng commented 4 months ago

Change the title so that other developers find the same problem could report it here.

The issue will be remained open for some time