Naming of the disablePolling argument

TREEcg / event-stream-client

Deprecated! Use the rdf-connect/ldes-client instead

https://github.com/rdf-connect/ldes-client

Other

14 stars 9 forks source link

Naming of the disablePolling argument #28

Closed pietercolpaert closed 3 years ago

pietercolpaert commented 3 years ago

I don’t think it’s disabling polling that is the intended feature. I think it’s the intended feature to onlyReplicate and to keep the replicated LDES in-sync

Can we rename this?

brechtvdv commented 3 years ago

Maybe call it: disableSynchronization ?

pietercolpaert commented 3 years ago

Agreed! However, make sure to keep the old property working for backwards compatibility reasons!

brechtvdv commented 3 years ago

Will be fixed here: https://github.com/TREEcg/event-stream-client/commit/31373ba83a586f3a9ec67192e86bac99804f39ec