search

TREX-CoE / trexio

TREX I/O library
https://trex-coe.github.io/trexio/
BSD 3-Clause "New" or "Revised" License
49 stars 14 forks source link

trexio --without-hdf5 needs hdf5 #125

Closed scemama closed 1 year ago

scemama commented 1 year ago

Johannes (the numerical AO contributor) has access to a cluster where HDF5 is not installed, and we were not able to use TREXIO: the text backend failed to its purpose!

When we do trexio --without-hdf5, the produced library still needs to call some hdf5 functions. We have missed some #ifdef HAVE_HDF5 in many places.

q-posev commented 1 year ago

The --without-hdf5 was working perfectly in the past, there were no missing HAVE_HDF5s. It broke down after tests refactoring because there was a typo in the unit tests for TEXT back end. I fixed it in another branch but has not pushed yet.

@scemama I think it might be better to rollback the last 2 commits and cherry-pick the commit 3b043768d86d25c2dcb096fbb88904cde385c290. To be confirmed, but I am 99% sure that it will fix the TEXT-only compilation :-)

You are trying to fix things inside trexio_hdf5.{c,h} but these files should not appear in the build process anyways when the HDF5 back end is deactivated (that's why #include trexio_hdf5.h is wrapped in HAVE_HDF5 check).

q-posev commented 1 year ago

Could you please test the latest commit and see if this bug is still there? You may need to run make maintainer-clean to make sure it's a clean installation.

scemama commented 1 year ago

OK, it seems good now! :-) On Thu, 2023-06-08 at 08:09 -0700, Evgeny Posenitskiy wrote:

Could you please test the latest commit and see if this bug is still there? You may need to run make maintainer-clean to make sure it's a clean installation.

— Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you were mentioned.Message ID: < @.***>