TRI-ML / dgp

ML Dataset Governance Policy for Autonomous Vehicle Datasets
https://tri-ml.github.io/dgp/
MIT License
93 stars 63 forks source link

Update build-docker.yml to run on 20.04 #112

Closed wadimkehl closed 2 years ago

wadimkehl commented 2 years ago

This PR ups the docker Ubuntu version to 20.04

This change is Reviewable

tk-woven commented 2 years ago

Thanks! I know this is in preparation for bumping things like xarray as well, so we should also bump the end-user Docker build file so that the canonical development environment is aligned with CI. We should also bump the base OS used in the other workflows as well. I can fiddle tomorrow if need be--for the development container I think we need to build locally, run the tests, and if those check out, leave a note here that things seem okay in the dev environment.

wadimkehl commented 2 years ago

Sure, thanks, but that's just the worker node, not the DGP environment. The PR failed because of commitlint. I'll close and make a new PR, as commitlint won't pick up post-PR-opened changes to the title and subject line.

tk-woven commented 2 years ago

Thanks. For posterity, we talked yesterday. The general idea is that we want our dev environment to be as close to our canonical CI environment as possible, so if one environment goes to Ubuntu 20, we should move the rest to 20 as well.