Closed tk-woven closed 1 year ago
Also, note that we use check-json
in place of SuperLinter's eslint
because eslint
is not automatically installed. We'd have to ask end-users to manually install it (if outside of Docker), which I find annoying.
Ah, also note that DGP has no checked-in shell files from what I can tell. However, to preserve SuperLinter coverage, we add shell-checking hooks since SuperLinter would provide them to us the moment we (maybe) introduce shell files.
Description
This is toward #114 . This moves more linting from SuperLinter to pre-commit. In particular, it moves
For
gitleaks
, we have to use a Docker-wrapped hook ID to avoid having our end-users manually install thegitleaks
tool themselves. Also, SuperLinter suggests that it runsshfmt
but is not entirely clear about it (since its configuration is forshellcheck
).This change is![Reviewable](https://reviewable.io/review_button.svg)