search

TRI-ML / dgp

ML Dataset Governance Policy for Autonomous Vehicle Datasets
https://tri-ml.github.io/dgp/
MIT License
94 stars 62 forks source link

schema: add instance and semantic segmentation 3D schema #143

Closed rachel-lien closed 1 year ago

rachel-lien commented 1 year ago

This change is Reviewable

rachel-lien commented 1 year ago

@yuta-tsuzuki-woven Can you review please? I'm not sure why a reviewable link didn't generate with this PR..

I had to make some edits to the .pre-commit-config.yaml in order to push schema updates, so please let me know if I should break that into a separate PR instead per contribution guidelines.

rachel-lien commented 1 year ago

dgp/proto/point_cloud.proto line 33 at r4 (raw file):

Previously, yuta-tsuzuki-woven wrote…
BTW, do we need to move these reserved enums to the top? and could you briefly add comments on why these are reserved? like "These channel types are deprecated. If you would like to use point cloud semantic/instance segmentation annotation, please use annotations.[Semantic/Instance]Segmentation3DAnnotations"

The values should be reserved within the ChannelType enum, not PointCloud, so I think it's already at the top?