TRI-ML / dgp

ML Dataset Governance Policy for Autonomous Vehicle Datasets
https://tri-ml.github.io/dgp/
MIT License
94 stars 62 forks source link

DGP Proto: Which Ontology message to be used? #35

Closed pd-nisse closed 2 years ago

pd-nisse commented 2 years ago

Currently there are two places with Ontology messages:

  1. https://github.com/TRI-ML/dgp/blob/80e387737d82b1474fdf7971f28a8fbbf66816a7/dgp/proto/dataset.proto#L18
  2. https://github.com/TRI-ML/dgp/blob/80e387737d82b1474fdf7971f28a8fbbf66816a7/dgp/proto/ontology.proto#L42

Could you confirm which is the one to be used in DGP 1.0 release implementation? Thank you!

quincy-kh-chen commented 2 years ago

Hello @pd-nisse,

Please use dgp/dgp/proto/ontology.proto https://github.com/TRI-ML/dgp/blob/80e387737d82b1474fdf7971f28a8fbbf66816a7/dgp/proto/ontology.proto#L42

Ontology in dgp/dgp/proto/dataset.proto is a deprecated message. We keep this deprecated message for some old datasets. Will remove it soon once all old Ontology got upgraded to dgp/dgp/proto/ontology.proto