search

TRI-ML / dgp

ML Dataset Governance Policy for Autonomous Vehicle Datasets
https://tri-ml.github.io/dgp/
MIT License
94 stars 62 forks source link

schema: add KeyPoint3D, KeyLine3D, Polygon3D #45

Open pd-nisse opened 2 years ago

pd-nisse commented 2 years ago

While KeyPoint2D, KeyLine2D, Polygon2D allow for point/line geomtries on the image plane, we would like to store the the 3D equivalents in carthesian coordinates in sensor space.

This change is Reviewable

pd-nisse commented 2 years ago

@quincy-kh-chen : Thanks for the comments! I re-ordered per your draft, but surface_normals_2D inhibits the index 13 already. How would you like to see this resolved?

pd-nisse commented 2 years ago

@quincy-kh-chen : I left the order as appending and built the proto files.

akira-wakatsuki commented 2 years ago

Hi @pd-nisse @quincy-kh-chen @yuta-tsuzuki-woven

I'm Akira from Woven Alpha. We are also interested in this PR and looking forward to getting this PR merged. All comments look resolved and let me ask what is remaining.

Thanks in advance.

nehalmamgain commented 2 years ago

Will get this moving.

nehalmamgain commented 2 years ago

Continuing discussion here