Working directory mismatch in Docker environment

TRI-ML / packnet-sfm

TRI-ML Monocular Depth Estimation Repository

https://tri-ml.github.io/packnet-sfm/

MIT License

1.24k stars 243 forks source link

Working directory mismatch in Docker environment #21

Closed tamamachi closed 4 years ago

tamamachi commented 4 years ago

Hi, In commit f41342d716a72e195a0e72cf12c6b563d182bb91, when you runmake doker-run and other Docker-related targets, the default working directory is set to /workspace/packnet-sfm/ but everything (code, data, confs...) is prepared under /workspace/packnet/ .

This leads python3 scripts/train.py checkpoint.ckpt to fail because train.py is at ../packnet/scripts/train.py.

VitorGuizilini-TRI commented 4 years ago

Thank you for pointing that out, I have pushed a quick fix and it should work now.

tamamachi commented 4 years ago

LGTM! Thank you for quick reply.