TRI-ML / packnet-sfm

TRI-ML Monocular Depth Estimation Repository
https://tri-ml.github.io/packnet-sfm/
MIT License
1.21k stars 241 forks source link

Details on Inv Depth Layer and ConstantPad2D #247

Open F-Barto opened 1 year ago

F-Barto commented 1 year ago

Hello,

I would like to know why are you explicitly using ConstantPad2D ?

[link to code]

self.conv1 = nn.Conv2d(in_channels, out_channels, kernel_size=3, stride=1)
self.pad = nn.ConstantPad2d([1] * 4, value=0)

From the doc nn.Conv2d default padding_mode is to zeros. Isn't setting padding=1 in Conv2d equivalent to your self.conv1(self.pad(x)) ?

Am I missing something ?

Have a good day