Open yukw777 opened 1 month ago
I just pushed a commit to pin timm==0.9.10
for the time being to make sure this doesn't break things for other folks.
I'd love it if you could push a PR, maybe add a test that verifies that results with different versions return the same output? Based on your PR, I can then test FSDP functionality and make sure everything checks out!
Great! A few questions for you:
unpack_seq()
, and it'd support both pre-1.0 timm and post-1.0 timm. If we do decide to drop support for timm < 1.0.0, I may just check for list
(and rename the function to unpack_list()
) and bubble up the error instead of eating it up.
timm v1.0.3 was just released 2 hours ago (https://github.com/huggingface/pytorch-image-models/releases/tag/v1.0.3) and it seems like they've reworked the API for
forward_intermediates()
and it returns a list instead of a tuple. As a result, when I runscripts.generate.py
with all the default settings and a simple questionIs the coffee cup empty?
, I get the following error:The following diff fixes the issue:
I'm happy to submit a PR for this, but seeing that this is related to monkey patching for FSDP support, I wanted to discuss how to properly fix it before moving forward.