search

TRIQS / ctseg

A segment picture impurity solver with spin-spin interactions.
https://triqs.github.io/ctseg
Other
7 stars 6 forks source link

Test dimer.py does not test anything #15

Open HugoStrand opened 1 week ago

HugoStrand commented 1 week ago

The test dimer.py does not check the result with any reference data, see https://github.com/TRIQS/ctseg/blob/3.3.x/test/python/dimer.py#L113

(Part of openjournals/joss-reviews#7425)

nkavokine commented 1 week ago

Dear Hugo, thanks for pointing this out. This is on purpose since for this particular test case, the results of short runs can exhibit large variations across platforms (see comment in the file header). This test is rather meant as a correctness test, since the result can be compared to ED (dimer_pyed.ref.h5). But a meaningful comparison would require a longer run than would be practical for an automatic test, therefore no comparison to a reference is carried out in this test as a default.