search

TRIQS / h5

A high-level C++ interface to the hdf5 library
https://triqs.github.io/h5
Other
3 stars 7 forks source link

Add cmake workaround for hdf5 version detection when using hdf5 with subversion #26

Closed Wentzell closed 1 month ago

Wentzell commented 1 month ago

Thank you @hmenke for the suggestions, I have updated the PR accordingly.

Wentzell commented 1 month ago

Note that the 1.13 version check is necessary and can't be dropped

Wentzell commented 1 month ago

Ok. Can I ask which hdf5 versions are affected by this issue?

hmenke commented 1 month ago

This started with 1.14.1. Before that the H5_VERS_SUBRELEASE suffix was only for release candidates, but with version 1.14.1-2 they started tagging full releases with it. https://github.com/HDFGroup/hdf5/tags