search

TRIQS / h5

A high-level C++ interface to the hdf5 library
https://triqs.github.io/h5
Other
3 stars 7 forks source link

Allowed custom key class in reading/writing of a map. #5

Closed chuffa closed 3 years ago

chuffa commented 3 years ago

String keys are written/read the exact same way as before ensuring backwards compatibility. This is also explicitly tested in one of the new tests which uses the old function for writing but the new one for reading. Feel free to delete this test if you think it is unnecessary, its purpose is to demonstrate that I tried to make sure that everything still works.

The other new test also serves as a template what needs to be implemented in a custom key class.

Best Daniel

Wentzell commented 3 years ago

@chuffa You can also rebase your PR branch onto h5/unstable. This should make sure that CI passes all tests.