fixed lapack/gelss.hpp and added lapack/gels.hpp

TRIQS / nda

C++ library for multi-dimensional arrays

https://triqs.github.io/nda

Other

13 stars 11 forks source link

fixed lapack/gelss.hpp and added lapack/gels.hpp #29

Closed mmorale3 closed 1 year ago

mmorale3 commented 1 year ago

1) Fixed several issues with lapack/gelss.hpp

type of C parameter, changed from MatrixView to VectorView.
C type should always be of non-complex type, change associated constrain in require clause
propagated changes in A and B function arguments when column major temporary arrays are used.
Calls to underlying f77::gelss routine is not performed directly on input A array. 2) Added lapack/gels.hpp following modified convention for gelss.hpp.

mmorale3 commented 1 year ago

I doubt this routine was ever used, since it has compilation problems as it was before. I made some changes in convention, for example, calling underlying f77:: routine on A array directly, rather than on a temporary. Let me know if you agree.

Wentzell commented 1 year ago

As discussed, it would be best to base these changes on the DEV_CUDA_LINALG development branch which contains many simplifications already in the BLAS / LAPACK interface.