search

TRIQS / nda

C++ library for multi-dimensional arrays
https://triqs.github.io/nda
Other
15 stars 12 forks source link

fix: BLAS batch strided needs sufficiently new MKL #49

Closed hmenke closed 1 year ago

hmenke commented 1 year ago

Just realized that there are no MKL tests in the CI, because I made a mistake in the original commit, yet the CI still passed.

Wentzell commented 1 year ago

Thank you @hmenke for adding this check.

I have enabled the ubuntul-intel builds in our Jenkins CI now also for nda.

Wentzell commented 1 year ago

Do you have a reference that shows that those functions were introduced in this specific version?

hmenke commented 1 year ago

I just guessed, because I noticed that it was present in 2020.4 but absent in 2020.0. Unfortunately it's not mentioned in the changelog when it was introduced so I just downloaded all past version from the repo and grepped through them, see the commit message.

hmenke commented 1 year ago

Please also cherry-pick this onto 1.2.x

Wentzell commented 1 year ago

Please also cherry-pick this onto 1.2.x

Done