search

TRIQS / solid_dmft

solid_dmft is a versatile python wrapper to perform DFT+DMFT calculations utilizing the TRIQS software library.
https://triqs.github.io/solid_dmft/
Other
32 stars 21 forks source link

Restore Python 3.8 compatibility for dictionary merge #63

Closed hmenke closed 1 year ago

hmenke commented 1 year ago

The | operator requires Python 3.9, which would then exclude Ubuntu 20.04 and other distros with older Python.

the-hampel commented 1 year ago

Are we sure we are not using any other Python 3.9 features already? @merkelm @alberto-carta Otherwise we can of course restore backward compatibility. TRIQS itself states 3.6, but I think some parts require newer Python versions.

hmenke commented 1 year ago

I've been using solid_dmft on Ubuntu 20.04 which has Python 3.8. Unfortuantely I developed #61 on a machine with Python 3.10 and the CI also runs Python 3.10, so I did not notice the compatibility problem.