search

TRIQS / tprf

TPRF: The Two-Particle Response Function tool box for TRIQS
https://triqs.github.io/tprf
Other
14 stars 12 forks source link

[eli] remove deprecated benchmark #23

Closed Stefan-Dienst closed 2 years ago

Stefan-Dienst commented 2 years ago

Remove old scripts to avoid confusion, see #22.

Wentzell commented 2 years ago

Which other implementation was this benchmark comparing against?

Stefan-Dienst commented 2 years ago

My first personal implementation without Triqs, which was never public.

Wentzell commented 2 years ago

Ok. Would it be much effort to fix the benchmark as it was previously working? These comparisons between different implementations are generally useful to keep around.

Stefan-Dienst commented 2 years ago

I generally agree, but in this case it won't be useful as this implementation was still in early testing stage and contained minor errors, which have then be fixed in the tprf implementation.

Wentzell commented 2 years ago

I see. You can go ahead with the merge then. This commit should also be applied to unstable I assume?

Stefan-Dienst commented 2 years ago

Yes, it should.

Wentzell commented 2 years ago

Could you please create the corresponding PR also for unstable? It seems your commit cannot simply be cherry-picked on unstable as some files have been moved.

Wentzell commented 2 years ago

@StefanKaeser

Wentzell commented 2 years ago

You can of course also just directly push this to unstable.

Stefan-Dienst commented 2 years ago

I have directly pushed this change to unstable.