search

TRIQS / tprf

TPRF: The Two-Particle Response Function tool box for TRIQS
https://triqs.github.io/tprf
Other
14 stars 12 forks source link

Dev lattice dyson gf #33

Closed YannIntVeld closed 2 years ago

YannIntVeld commented 2 years ago

We noticed that the lattice_dyson_g functions in the gf.cpp file were not thread safe. In this PR this is fixed by initializing the Green functions to zero before performing the parallelized loop.

In addition the code was cleaned up by defining a generic for the lattice_dyson_g functions and by removing the CMake option 'enable extra OpenMP threading', which was only used in the gf.cpp file and we believe to be unnecessary.

Finally a test was added for the lattice_dyson_g functions.

HugoStrand commented 2 years ago

Dear Yann,

Thank you for the contribution! The changes looks good.

Thank you for cleaning up the preprocessor statements. They were a remnant from the early tests with hybrid parallelisation.

Best, Hugo