Expected behavior: When using cmake's find_package(TRIQS "min_version...max_version") and a found TRIQS version >max_version, TRIQS should tell cmake that there is no suitable version found.
Actual behavior: TRIQS tells cmake a suitable version is found when there is not, and will try build against that version.
This issue was discussed here: krivenko/ezARPACK#7.
From the cmake manual it specifies that when a range of versions is given, it essentially sets PACKAGE_FIND_VERSION to the minimum version in the range for backwards compatability. The TRIQS version checking only uses this variable, instead of the PACKAGE_FIND_VERSION_MIN and PACKAGE_FIND_VERSION_MAX variables.
The TRIQSConfig-version.cmake.in file needs to include the below to work with ranges:
if (PACKAGE_FIND_VERSION_MAX VERSION_LESS PACKAGE_VERSION)
set(PACKAGE_VERSION_UNSUITABLE TRUE)
endif()
if (PACKAGE_FIND_VERSION_MIN VERSION_GREATER PACKAGE_VERSION)
set(PACKAGE_VERSION_UNSUITABLE TRUE)
endif()
Or, at least the first one, because the min_version is handled by the PACKAGE_FIND_VERSION variable. But there is likely no harm in using both checks.
Additional Information
TRIQS minimum cmake version is 3.20. Ranges in find_package was introduced in cmake version 3.19.
Version
TRIQS library version 3.2.0
git hash 90c8f8c257be434bc4560f4bbc518905c4d226ea
Wentzell
commented
10 months ago
Expected behavior: When using cmake's
find_package(TRIQS "min_version...max_version")and a found TRIQS version>max_version, TRIQS should tell cmake that there is no suitable version found.Actual behavior: TRIQS tells cmake a suitable version is found when there is not, and will try build against that version.
This issue was discussed here: krivenko/ezARPACK#7.
From the cmake manual it specifies that when a range of versions is given, it essentially sets
PACKAGE_FIND_VERSIONto the minimum version in the range for backwards compatability. The TRIQS version checking only uses this variable, instead of thePACKAGE_FIND_VERSION_MINandPACKAGE_FIND_VERSION_MAXvariables.The
TRIQSConfig-version.cmake.infile needs to include the below to work with ranges:Or, at least the first one, because the
min_versionis handled by thePACKAGE_FIND_VERSIONvariable. But there is likely no harm in using both checks.Additional Information
TRIQS minimum cmake version is
3.20. Ranges infind_packagewas introduced in cmake version3.19.Version
TRIQS library version 3.2.0 git hash 90c8f8c257be434bc4560f4bbc518905c4d226ea