Closed nstange closed 11 years ago
Hi Nicolai,
Sorry for the late answer, most of us were either on summer schools or holidays in august. I will have a closer look at the HDF_Archive.py code. You are probably right. Actually there is a number of things which are now obsolete in the script. I should spend some time to clean it up and take care of issue #49 on the way.
I'll let you know when I'm done with this. Cheers!
Took some time but I finally cleaned up the archive file. Deprecated things have been removed. Should be clearer now.
Hi,
reading HDF_Archive.py, it seems to me that in the call to factory_from_hdf5() from HDF_Archive_group.getitem1(), no information about from which subgroup to deserialize is passed. In my opinion, either the key or even better, SUB should be passed.
Not so important for me, but I guess the same holds for read_hdf5().
Another minor note: I believe that the code around the call to write_hdf5() from HDF_Archive_group.setitem() isn't functional anymore: Grep tells me that neither out nor path2 are defined somewhere...
Best,
Nicolai