Closed johausmann closed 1 year ago
Patch coverage: 100.00
% and project coverage change: +0.45
:tada:
Comparison is base (
2a5f11b
) 83.17% compared to head (8959fdb
) 83.63%.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.
There are a couple of codacy style issues referring to an usused import from sqlalchemy.orm import relationship
. But you will use this soon so... In any case, checkout codacy, sometimes provides useful info.
There is something about adding FKs that may need explanation or maybe not, but just in case here it goes.
If you add an FK to the model in an existing table when you create the database from scratch it will work just fine, but if you have an existing DB (as our development DB or our production DB) you will actually need to alter the database manually to add the FK. I have been adding these DB patches under scripts/sql
, you basically need an alter SQL script that does the trick. Be careful you may break the DB, but if you do break it we have backup in any case.
Related to #61
This merge request adds the lineage annotations based on the constellation files from scorpio.