search

TRSasasusu / TranslationForTheOutsider

Universal translation for The Outsider; EN -> JA, pt-BR, zh-CN, RU, FR, DE, IT (making others are welcoming!) And patches to solve some issues of The Outsider
https://outerwildsmods.com/mods/translationandpatchesfortheoutsider/
MIT License
5 stars 7 forks source link

NH compat, cleanup, remove unused nh save data #34

Closed xen-42 closed 7 months ago

xen-42 commented 7 months ago

Only other change that is required is a PR to the main Outsider repo to remove NH from the mod conflicts list

Some changes to NH must be merged first, so this will happen after https://github.com/Outer-Wilds-New-Horizons/new-horizons/pull/805 is merged

TRSasasusu commented 7 months ago

Thank you for making NH compatible PR! It would be very helpful for people running the vision and the outsider in the same time ::)

But, ... please, please remove unnecessary diffs due to formatting (i.e., diffs about spaces -> tabs, () {\n -> ()\n{, ...)

And, what is libs/TheOutsider.dll? Could it be generated by GitHub Actions? (I would like to generate dll files by GitHub Actions in terms of authenticity.)

xen-42 commented 7 months ago

but the new formatting looks better! At least doing ()\n{ is the C# convention and () {\n is technically incorrect, but I'll look into fixing the spaces to tabs

TheOutsider.dll is the dll of the original mod and its required to patch it. It's included in the repo so that the github action can run. I think it's possible to check out the release of the original mod in an action and grab the dll but that would be really complicated for no real gain, especially since the original is abandoned and will not be updated anymore. That dll does not end up getting included in the release, its just to allow the action to run

xen-42 commented 7 months ago

Fixed the spaces

TRSasasusu commented 7 months ago

TheOutsider.dll is the dll of the original mod and its required to patch it. It's included in the repo so that the github action can run.

Are you meaning integrating this mod and the outsider (this mod into the outsider / the outsider into this mod)?

Anyway, I am looking at https://github.com/StreetlightsBehindTheTrees/Outer-Wilds-The-Outsider/pull/12 and https://github.com/Outer-Wilds-New-Horizons/new-horizons/pull/805 .

(And, I'm curious why did you move Harmony.CreateAndPatchAll(Assembly.GetExecutingAssembly()); from Awake() to Start().)

xen-42 commented 7 months ago

Hmm yeah I think it was because I was trying to debug the patches not working, but in the end I was just doing it wrong. I'll move it back to awake. But yes, this mod will just be merged into the Outsider so I'm going to close this PR