TRU-PBADS / ADSC_3910_students

0 stars 0 forks source link

Peer Review: Lung Cancer Prediction Group 4 #3

Closed viswatejaadothi closed 1 week ago

viswatejaadothi commented 1 week ago

Peer Review: Lung Cancer Prediction

Reviewer Name: Viswateja Adothi

IMPORTANT: As a reviewer, you will need to clone their github repo and attempt to reproduce the whole data science pipeline. Document the issues as you come across it so it can help the groups improve later on.

1. Project Structure (25%)

Repository Organization:

The project structure is quite good

Naming Conventions:

Few files are named as per the snake_case format

README File:

Is very well formatted all the steps are included.


2. Code Quality (25%)

Code Readability and Structure:

Feedback on the clarity, conciseness, and formatting of the code. code clarity ,formatting and conciseness are good

Modularization:

Organization of the code into distinct scripts and functions is quite good

Version Control:

Feedback on the use of Git version control, including commit frequency and documentation. The commit frequency is quite good and documentation is well structured


3. Reproducible Environment (25%)

You will need to try to re-run the whole pipeline

Environment Setup:

_Readme is with all steps and easy to understand will all steps included

Reproducibility test

4. Application of MongoDB and PySpark (25%)

MongoDB Usage:

Mongo db is used for connecting db and but did not find any preprocessing or cleaning steps using mongo db

PySpark Usage:

Could not find any pyspark files commited.


5. Rating (Optional)


End of Review

viswatejaadothi commented 1 week ago

They are not able to see hence closing from my side