TRaSH-Guides / Guides

Here you will find Guides mainly for the Starr Apps (Sonarr/Radarr) and everything related to it.
https://trash-guides.info/
MIT License
1.81k stars 226 forks source link

[Bug] Recyclarr: Incorrect usage of reset_unmatched_scores #1256

Closed uhthomas closed 1 year ago

uhthomas commented 1 year ago

Which Guide

https://trash-guides.info/Recyclarr/recyclarr-configs

Describe the Error in the Guide

The configs use reset_unmatched_scores for quality_profiles where they shouldn't.

Expected behavior

According to the documentation and schema, there are two kinds of quality profile.

Example schema:

radarr: [string]: {
    quality_profiles: [...{
        name: string
        reset_unmatched_scores: bool
    }]
    custom_formats: [...{
        quality_profiles: [...{
            name: string
            score: int
        }]
    }]
}

The field reset_unmatched_scores is incorrectly being used for the custom format quality profile, which doesn't exist.

It looks like it used to, though.

https://github.com/recyclarr/recyclarr/blob/503cb7500a81076ff0c1e9279152ebf23418fd62/src/Recyclarr.TrashLib/Pipelines/QualityProfile/PipelinePhases/QualityProfileConfigPhase.cs#L97-L100

Screenshots

N/A

Additional context

N/A

yammes08 commented 1 year ago

This was deprecated with the latest release of recyclarr, which only came out 7 hours ago 😄 I should be able to take a look at this today.

Edit: It's not actually deprecated in this release, but marked for deprecation in V5 with log output to advise of that. The current configuration files are still valid, but I can update them now as the latest v4.4.0 release supports the new configuration.

yammes08 commented 1 year ago

These will be updated with PR #1257