TRaSH-Guides / Guides

Here you will find Guides mainly for the Starr Apps (Sonarr/Radarr) and everything related to it.
https://trash-guides.info/
MIT License
1.89k stars 229 forks source link

[Bug] CF for x265 does not include HEVC #1600

Closed gjobin closed 1 year ago

gjobin commented 1 year ago

Guide Name

Description

Comparing the x265 related CF's, the basic one does not properly include "HEVC" like the other do.

image

Thank you.

Expected Behavior

HEVC should match x265 custom format.

Screenshots

No response

Additional Context

Applies to both Sonarr and Radarr

bakerboy448 commented 1 year ago

Condition Naming issue only; not a material bug

the CF still includes hevc

"[xh][ ._-]?265|\bHEVC(\b|\d)"

gjobin commented 1 year ago

Condition Naming issue only; not a material bug

the CF still includes hevc

"[xh][ ._-]?265|\bHEVC(\b|\d)"

That is interesting, cause the CF label did not show on a movie containing HEVC. There definitely are cases where it does not seem to work as expected, but would like to understand if I am mistaken. You're right though, labeling does'nt matter, and did not check down to the Regex.

Working Case :

image

Seemingly incorrect case :

image
bakerboy448 commented 1 year ago

Non-issue x265 is confined to REMUX releases only. Not BR-DISK

gjobin commented 1 year ago

Makes sense. Sorry I did not catch that.