TRaSH-Guides / Guides

Here you will find Guides mainly for the Starr Apps (Sonarr/Radarr) and everything related to it.

https://trash-guides.info/

MIT License

1.64k stars 207 forks source link

feat(guide): Update naming scheme and add tvdb/tmdb #1965

Closed TRaSH- closed 1 month ago

TRaSH- commented 1 month ago

Pull Request

Purpose

Update Radarr/Sonarr Recommended naming scheme

Approach

Update Radarr/Sonarr Recommended naming scheme and add TVDb/TMDb option

Open Questions and Pre-Merge TODOs

[x] Updated Radarr Recommended naming scheme
[x] Added TMDb
[x] Updated radarr-naming.json for 3rd party sync
[x] Updated Sonarrr Recommended naming scheme
[x] Added TVDb
[x] Updated sonarr-naming.json for 3rd party sync

Requirements

[x] These changes meet the standards for contributing.
[x] I have read the code of conduct.

TRaSH- commented 1 month ago

added: do not merge label, because @rcdailey needs to check if the version removable for the sonarr-naming.json isn't hardcoded in to recyclarr @austinwbest already mentioned in discord that notifiarr will fallback to the default without version

rcdailey commented 1 month ago

@TRaSH- Thanks for giving me a chance to refresh my memory on the logic that Recyclarr uses. The behavior is the same as Notifiarr -- If default:3 doesn't exist (in the case of Sonarr v3) it will fall back to default which appears to be the Sonarr v4 naming scheme now. My only concern is that users still on Sonarr v3 will have their naming changed to Sonarr v4 and won't be notified of the change; but hopefully not many people are using Sonarr v3 these days.

I'm not overly concerned. I think that we're good to merge this. Thanks again for thinking of me!