emoticon cannot be transfer

[GoogleCodeExporter]

What steps will reproduce the problem?
1. sending a emoticon in chat
2. error will print out in vs output windows

What is the expected output? What do you see instead?
can no error to run and receive the event to OnMessageReceived and go to the 
case "case MessageType.Emoticon:"

What version of the product are you using? (MSNPSharp, OS, Mono etc.)
MSNPSharp_DEV, Win7 

Is your code check out from SVN or download from our download site?
from SVN MSNPSharp_DEV

Please provide any additional information below:

Exception location:
MessageManager.cs Line 96
   ConversationID id = ProcessArrivedConversation(sender as Conversation);
It pass a null value into ProcessArrivedConversation !! And throw out a 
exception that cannot continue to receive the emoticon

Error stack
---------------------------

There is(are) 0 P2PTransferSession still in this 
MSNPSharp.DataTransfer.P2PMessageSession
Conversation: Emoticon received
A first chance exception of type 'System.ArgumentNullException' occurred in 
MSNPSharp.dll
SBMessageProcessor: System.ArgumentNullException: 值不能為 null。
參數名稱: conversation is null.
   於 MSNPSharp.Utilities.ConversationID..ctor(Conversation conversation) 於 D:\Visual Studio 2008\Projects\msn\src\MSNPSHARP_DEV\MSNPSharp\ConversationID.cs: 行 60
   於 MSNPSharp.Utilities.MessageManager.ProcessArrivedConversation(Conversation conversation) 於 D:\Visual Studio 2008\Projects\msn\src\MSNPSHARP_DEV\MSNPSharp\MessageManager.cs: 行 116
   於 MSNPSharp.Utilities.MessageManager.MSNObjectDataTransferCompleted(Object sender, MSNObjectDataTransferCompletedEventArgs e) 於 D:\Visual Studio 2008\Projects\msn\src\MSNPSHARP_DEV\MSNPSharp\MessageManager.cs: 行 96
   於 MSNPSharp.Conversation.OnMSNObjectDataTransferCompleted(Object sender, MSNObjectDataTransferCompletedEventArgs e) 於 D:\Visual Studio 2008\Projects\msn\src\MSNPSHARP_DEV\MSNPSharp\Conversation.cs: 行 364
   於 MSNPSharp.Conversation.transferSession_TransferFinished(Object sender, EventArgs e) 於 D:\Visual Studio 2008\Projects\msn\src\MSNPSHARP_DEV\MSNPSharp\Conversation.cs: 行 136
   於 System.EventHandler`1.Invoke(Object sender, TEventArgs e)
   於 MSNPSharp.DataTransfer.P2PTransferSession.OnTransferFinished() 於 D:\Visual Studio 2008\Projects\msn\src\MSNPSHARP_DEV\MSNPSharp\DataTransfer\P2PTransferSession.cs: 行 824
   於 MSNPSharp.DataTransfer.P2PTransferSession.HandleMessage(IMessageProcessor sender, NetworkMessage message) 於 D:\Visual Studio 2008\Projects\msn\src\MSNPSHARP_DEV\MSNPSharp\DataTransfer\P2PTransferSession.cs: 行 579
   於 MSNPSharp.DataTransfer.P2PMessageSession.HandleMessage(IMessageProcessor sender, NetworkMessage message) 於 D:\Visual Studio 2008\Projects\msn\src\MSNPSHARP_DEV\MSNPSharp\DataTransfer\P2PMessageSession.cs: 行 509
   於 MSNPSharp.DataTransfer.P2PHandler.HandleMessage(IMessageProcessor sender, NetworkMessage message) 於 D:\Visual Studio 2008\Projects\msn\src\MSNPSHARP_DEV\MSNPSharp\DataTransfer\P2PHandler.cs: 行 617
   於 MSNPSharp.SBMessageProcessor.DispatchMessage(NetworkMessage message) 於 D:\Visual Studio 2008\Projects\msn\src\MSNPSHARP_DEV\MSNPSharp\SBMessageProcessor.cs: 行 98
Stacktrace:
   於 MSNPSharp.Utilities.ConversationID..ctor(Conversation conversation) 於 D:\Visual Studio 2008\Projects\msn\src\MSNPSHARP_DEV\MSNPSharp\ConversationID.cs: 行 60
   於 MSNPSharp.Utilities.MessageManager.ProcessArrivedConversation(Conversation conversation) 於 D:\Visual Studio 2008\Projects\msn\src\MSNPSHARP_DEV\MSNPSharp\MessageManager.cs: 行 116
   於 MSNPSharp.Utilities.MessageManager.MSNObjectDataTransferCompleted(Object sender, MSNObjectDataTransferCompletedEventArgs e) 於 D:\Visual Studio 2008\Projects\msn\src\MSNPSHARP_DEV\MSNPSharp\MessageManager.cs: 行 96
   於 MSNPSharp.Conversation.OnMSNObjectDataTransferCompleted(Object sender, MSNObjectDataTransferCompletedEventArgs e) 於 D:\Visual Studio 2008\Projects\msn\src\MSNPSHARP_DEV\MSNPSharp\Conversation.cs: 行 364
   於 MSNPSharp.Conversation.transferSession_TransferFinished(Object sender, EventArgs e) 於 D:\Visual Studio 2008\Projects\msn\src\MSNPSHARP_DEV\MSNPSharp\Conversation.cs: 行 136
   於 System.EventHandler`1.Invoke(Object sender, TEventArgs e)
   於 MSNPSharp.DataTransfer.P2PTransferSession.OnTransferFinished() 於 D:\Visual Studio 2008\Projects\msn\src\MSNPSHARP_DEV\MSNPSharp\DataTransfer\P2PTransferSession.cs: 行 824
   於 MSNPSharp.DataTransfer.P2PTransferSession.HandleMessage(IMessageProcessor sender, NetworkMessage message) 於 D:\Visual Studio 2008\Projects\msn\src\MSNPSHARP_DEV\MSNPSharp\DataTransfer\P2PTransferSession.cs: 行 579
   於 MSNPSharp.DataTransfer.P2PMessageSession.HandleMessage(IMessageProcessor sender, NetworkMessage message) 於 D:\Visual Studio 2008\Projects\msn\src\MSNPSHARP_DEV\MSNPSharp\DataTransfer\P2PMessageSession.cs: 行 509
   於 MSNPSharp.DataTransfer.P2PHandler.HandleMessage(IMessageProcessor sender, NetworkMessage message) 於 D:\Visual Studio 2008\Projects\msn\src\MSNPSHARP_DEV\MSNPSharp\DataTransfer\P2PHandler.cs: 行 617
   於 MSNPSharp.SBMessageProcessor.DispatchMessage(NetworkMessage message) 於 D:\Visual Studio 2008\Projects\msn\src\MSNPSHARP_DEV\MSNPSharp\SBMessageProcessor.cs: 行 98

Original issue reported on code.google.com by hmcher...@gmail.com on 21 Jun 2010 at 5:44

Attachments:

• screen.zip

[GoogleCodeExporter]

It should be sending a emoticon from wlm adn receive by MSNPSharp.
The error will occur when MSNPSharp receive the emoticon

Original comment by hmcher...@gmail.com on 21 Jun 2010 at 5:46

[GoogleCodeExporter]

Hi,
Thank you for your report, I will fix it as soon as possible.
By the way, the _DEV version is still under develop, thanks for your testing. 
If you want to use a stable version, you can check out the code from 
branches/MSNPSHARP_30_STABLE/ .

Thanks again for your report, if you have further question, please send me 
email.

Regards,
Pang

Original comment by freezing...@gmail.com on 22 Jun 2010 at 4:25

[GoogleCodeExporter]

Original comment by freezing...@gmail.com on 22 Jun 2010 at 4:25

• Changed state: Accepted

[GoogleCodeExporter]

Hi Pang,

I compare MSNPSHARP_30_STABLE, MSNPSHARP_312_BETA and MSNPSHARP_DEV and they 
are different code pattern. Also, it has some feature not available on 
MSNPSHARP_30_STABLE. Which version should I use?

Regards,
Herman

Original comment by hmcher...@gmail.com on 22 Jun 2010 at 6:24

[GoogleCodeExporter]

Hi Herman,

If you want to deliver you product, I recommend you to use the stable version. 
However, if you want to try out the new version, DEV is ok. DEV version will 
provide backward compatibility once it's released. Don't worry about the design 
pattern.

Regards,
Pang WU

Original comment by freezing...@gmail.com on 23 Jun 2010 at 6:04

[GoogleCodeExporter]

Dear Herman,

I've fixed this bug and the DEV version is relatively stable. If you don't 
mind, you can develop your product on it.

Regards,
Pang WU

Original comment by freezing...@gmail.com on 24 Jun 2010 at 10:23

• Changed state: Fixed

[GoogleCodeExporter]

Original comment by freezing...@gmail.com on 24 Jun 2010 at 10:24

• Added labels: Milestone-Release3.1.0