search

TReKiE / msnp-sharp

Automatically exported from code.google.com/p/msnp-sharp
0 stars 0 forks source link

TASK: Remove ContactInfo, MembershipContactInfo #22

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
1) Classes to remove:
ContactInfo, MembershipContactInfo

2) Update Contact class: 
GetHashCode() { mail.GetHashCode() - type.GetHashCode }
Remove ContactIdentifier. Contact.GetHashCode() =
ContactIdentifier.GetHashCode()

3) Remove MembershipContacts from XMLContactList
Add SerializableDictionary<Service, SerializableDictionary<MemberRole,
SerializableDictionary<int, BaseMember>>> a = new
SerializableDictionary<Service, SerializableDictionary<MemberRole,
SerializableDictionary<int, BaseMember>>>();

SerializableDictionary<int, BaseMember> = is Contact.HashCode, BaseMember

Original issue reported on code.google.com by hepha...@gmail.com on 27 Aug 2008 at 12:15

GoogleCodeExporter commented 9 years ago 
public override int GetHashCode()
{
  return mail.GetHashCode() - clienttype.GetHashCode();
}

I think this is not a good idea, because mail.GetHashCode() - 
clienttype.GetHashCode
() may result the same between two contacts

Original comment by freezing...@gmail.com on 6 Sep 2008 at 12:41

GoogleCodeExporter commented 9 years ago

Original comment by freezing...@gmail.com on 3 Nov 2008 at 8:11