Adding Yahoo contacts

[GoogleCodeExporter]

What steps will reproduce the problem?
1. Setup new Yahoo account under "yahoo.com.tw" domain.
2. Add a Yahoo contact with either
messenger.Nameserver.ContactService.AddNewContact(account) or 
messenger.Nameserver.ContactService.AddNewContact(account,
ClientType.EmailMember, invitation).
I've also tried setting the IM type as ClientType.PassportMember just to 
try out different things.

What is the expected output? What do you see instead?
Expected
The Yahoo contact should be added to the contact list and the Yahoo 
Messenger client should receive an invitation to add the BOT.

Result
The Yahoo contact is added to the contact list, but the Yahoo Messenger 
client did NOT get the invite.

What version of the product are you using? On what operating system?
2.5.3 on Vista.

Please provide any additional information below.
There seems to be some problems with Yahoo contacts, I'm not sure if they 
are caused by MS or the library.
1. Adding new Yahoo contacts doesn't always succeed. Sometimes Yahoo 
   Messenger doesn't get the added/invite message.
2. Yahoo contacts' online status are not delivered all the time.
These are the two major problems that I've encounter with Yahoo contacts.

Original issue reported on code.google.com by kuan...@gmail.com on 3 Feb 2009 at 9:49

[GoogleCodeExporter]

Hi,

Fixed. Now, AddNewContact(string account, ClientType network) is an internal 
method.
You must use AddNewContact(hotmail or yahoo or phone) to add new contact.

We queries other networks (FQY: Forward Query) automatically when you add a new
contact. If FQY response is OK t=32(yahoo network), we add yahoo members too...

Just specify an email address... We add 2 contacts automatically if available.

Please upgrade your code or don't use  AddNewContact("xxx@hotmail.com",
ClientType.EmailMember), because hotmail isn't yahoo contact.

http://msnp-sharp.googlecode.com/svn/branches/MSNPSHARP_25_STABLE
http://msnp-sharp.googlecode.com/svn/trunk

Thanks for the report.

Original comment by hepha...@gmail.com on 3 Feb 2009 at 11:44

• Changed state: Fixed
• Added labels: Milestone-Release2.5.4

[GoogleCodeExporter]

Hi,

Thanks for the tip.

I'm using that function is because I wanted to set the invitation message. 
After some 
testing, seems that the invitation message is not supported by all MS clients.
I guess I'll stick to the basic add for now.

Original comment by kuan...@gmail.com on 4 Feb 2009 at 2:49

[GoogleCodeExporter]

Hi,

I've downloaded MSNPSHARP_25_STABLE and tested it, unfortunately I'm still 
having
trouble with this.

Now I'm using AddNewContat('xxx@yahoo.com.tw').
The contact is added to the bot account, however, the YM client is still not 
getting 
the *add* invite and no online status event for the bot ever.
I've also tried previously added YM contacts, no online event either.
(Sending message works fine tho)

Do I need to do something different to handle YM contacts!?
Or is it simply the integration YM into MSN is just not that good?

PS. I've emailed the bot account info to you just in case you needed it.

Attached is the trace info when I tried to add 2 yahoo.com.tw contacts.

Original comment by kuan...@gmail.com on 4 Feb 2009 at 4:13

Attachments:

• MSNPLibLog.txt

[GoogleCodeExporter]

I have added msnpsharp@yahoo.com, and the Yahoo! messenger says:

"GoYou情報員(反) (gy-bot@live.com) has requested to add you to their online 
list."
"Accept" "Decline"

You must ACCEPT TO SEE ONLINE status and yahoo messenger hasn't a invitation 
message
for yahoo contacts. It is only for passport members. When I accept it is online.

NSMessageProcessor: Parsing incoming NS command...
NSMessageProcessor: Dispatching incoming NS command: NLN NLN 
32:msnpsharp@yahoo.com
msnpsharp@yahoo.com 8390656:0 0 https://sec.yimg.com/i/us/nt/b/purpley.1.0.png

Original comment by hepha...@gmail.com on 4 Feb 2009 at 10:20

[GoogleCodeExporter]

That's the problem, I didn't get the accept request.
I tried 4 new Yahoo.com.tw contacts and none of them got the accept request.

Am I suppose to see that trace message after adding a Yahoo contact?
I don't remember seeing that during my trials. I'll do some more tests 
today on different Yahoo contact in different domains.

Also, did you perform your test using the library example DotMSNClient?

Thanks you for your help.

Original comment by kuan...@gmail.com on 5 Feb 2009 at 2:08

[GoogleCodeExporter]

I figure out what the problem is.

For others that might encounter this problem.
MSN does NOT recognize contacts in other domains except yahoo.com.
I need to manually strip off the country code after yahoo.com.

For example, if I want to register a Yahoo contact 'abc@yahoo.com.tw', the 
address 
that I call with AddNewContact should be 'abc@yahoo.com' without the country 
code 'tw'.
Seems that all users under yahoo.com(.xx) are treated equally.

Again, thanks a lot for helping me with this problem.

Original comment by kuan...@gmail.com on 5 Feb 2009 at 3:39

[GoogleCodeExporter]

Ok, this bug is very helpful for us.
You don't need strip off anymore.
See r952.
Just add abc@yahoo.com.tw

Original comment by hepha...@gmail.com on 24 Mar 2009 at 12:06