search

TS-CUBED / CirculatorySystemModels.jl

MIT License
16 stars 5 forks source link

subbed D(fun(t)) to Chamber for undefined DE #24

Closed justidy1 closed 9 months ago

justidy1 commented 9 months ago

Addresses issue here: https://github.com/TS-CUBED/CirculatorySystemModels.jl/issues/23

DE was undefined in Chamber, so using the Differential operator to calculate DE from argument fun

codecov-commenter commented 9 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (1fff439) 40.21% compared to head (1b63244) 40.21%. Report is 2 commits behind head on main.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #24 +/- ## ======================================= Coverage 40.21% 40.21% ======================================= Files 1 1 Lines 373 373 ======================================= Hits 150 150 Misses 223 223 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

TS-CUBED commented 9 months ago

Thank you for this. I fixed it another way. This was missing a scaling factor in the derivative and was in terms of p, while I moved the standard to in terms of V (only DHChamber is staying in p).

Could you test the new version in "main" and let me know if it works? Note: parameter "E" is now "Escale"!