TSYS-Merchant / stumps

Apache License 2.0
3 stars 3 forks source link

Enhance create website functionality #42

Closed sblackmore-mw closed 10 years ago

sblackmore-mw commented 10 years ago
dlachowicz-mw commented 10 years ago

1) Move logic from Issue #45 (https://github.com/merchantwarehouse/stumps/commit/7eb19ea5477f5831237e0ec47f992dd26320d769) to the JavaScript level 2) Validate the the URI is reachable. If you get a Socket Connection issue, report that to the user 3) If a user types in "www.foo" without a TLD, this should cause an error message to be displayed

sblackmore-mw commented 10 years ago

Should the javascript UI enhancements now be moved to a future enhancement MVF and out of this milestone since the C# code takes care of a lot of the validation?

dlachowicz-mw commented 10 years ago

From a usability PoV, they really belong in the Javascript/HTML layer. But I have no preference for whether this gets done in this MVF or the next one.

mwmharrington commented 10 years ago

I second that - the validation should be in the Javascript/HTML layer. It provides the best user experience to know there's a problem before the problem happens. I have a futureish hopeful goal of the HTML being static with everything being performed through the REST API (which will still need to validate, but only as a last-ditch sanity check).