TTLabs / EvaporateJS

Javascript library for browser to S3 multipart resumable uploads
1.82k stars 207 forks source link

Use URL.host when generating headers to sign #408

Closed mojodna closed 4 years ago

mojodna commented 6 years ago

host includes the port number (necessary for generating correct signatures when using S3 endpoints on non-standard ports) where hostname does not.

omaraltayyan commented 4 years ago

can anyone approve this, this fixes the issue for minio users so it's very important, it has been stated in #317 that it's incompatible with IE but that browser is getting deprecated by Microsoft lately