Bodysearch: Local results overwrite policing results in the scoreboard

[EntranceJew]

Your version of TTT2 (mandatory)

Leave one of the following:

• Latest GitHub version

Describe the bug (mandatory)

corpses don't get marked as detective peeped

To reproduce

Steps to reproduce the behavior:

1. Begin a round as an innocent.
2. Have a player kill another player.
3. Have any non-detective, non-you player check the body with instant-confirm enabled.
4. The corpse will display as confirmed.
5. Have a detective inspect the confirmed corpse.
6. The corpse will not show the "This body has been inspected by a public policing role" targetid info.
7. The scoreboard row for that corpse will not have been updated to show the magnifying glass to display corpse information.

Expected behaviour

• The corpse shows the blue flare.
• The scoreboard is adequately updated.

Context (please provide as much as you can)

• This might be mitigated by #1260, idk.
• If you are a detective, you will always observe this as functioning correctly -- because local search results still preside over publicly available knowledge. You must remain an innocent to see this occur.

[TimGoll]

It is working in the scoreboard, I'll check if it also works in targetID later today

[TimGoll]

I can not reproduce this issue, it works on my end. It was probably fixed "on accident" in another PR.

[Histalek]

I can not reproduce this issue, it works on my end. It was probably fixed "on accident" in another PR.

If you are a detective, you will always observe this as functioning correctly -- because local search results still preside over publicly available knowledge. You must remain an innocent to see this occur.

how did you test this specifically?

[TimGoll]

I can not reproduce this issue, it works on my end. It was probably fixed "on accident" in another PR.

If you are a detective, you will always observe this as functioning correctly -- because local search results still preside over publicly available knowledge. You must remain an innocent to see this occur.

how did you test this specifically?

I killed the player, set my role as dete, confirmed it and changed my role again

[Histalek]

I can not reproduce this issue, it works on my end. It was probably fixed "on accident" in another PR.

If you are a detective, you will always observe this as functioning correctly -- because local search results still preside over publicly available knowledge. You must remain an innocent to see this occur.

how did you test this specifically?

I killed the player, set my role as dete, confirmed it and changed my role again

so this is still an issue. Reopening.

[TimGoll]

no, it isn't. The workflow described in the issue produces the same. I tested this. Feel free to test yourself.

[Histalek]

This was not reproducible in our testsession.

Please reopen if you encounter this again.

[EntranceJew]

https://github.com/TTT-2/TTT2/assets/5711436/d5edee2e-4541-49f9-ab2f-4f0798c759c4 if i check a corpse a detective checked, then it overwrites it with my local results both on the corpse and on the scoreboard

[EntranceJew]

reopen