TTT-2 / TTT2

Trouble in Terrorist Town 2 for Garry's Mod (gmod)
https://steamcommunity.com/sharedfiles/filedetails/?id=1357204556
178 stars 74 forks source link

Remove Addons from Checker #696

Closed dhkatz closed 3 years ago

dhkatz commented 3 years ago

Your version of TTT2 (mandatory)

v0.7.4b (Workshop)

Describe the bug (mandatory)

Currently some of my addons are listed inside sv_addonchecker.lua

https://github.com/TTT-2/TTT2/blob/a1fb79d16f253208d4c91205e3746a4e0cd0b9b8/gamemodes/terrortown/gamemode/server/sv_addonchecker.lua#L180

https://github.com/TTT-2/TTT2/blob/a1fb79d16f253208d4c91205e3746a4e0cd0b9b8/gamemodes/terrortown/gamemode/server/sv_addonchecker.lua#L260

I have updated these addons to fully support TTT2 (as well as my other TTT addons), including ULX menu support where applicable. Therefore I believe they should be removed from the addon checker now.

The source repositories for the addons in question are here:

https://github.com/gmod-workshop/ttt-clairvoyancy

https://github.com/gmod-workshop/ttt-martyrdom

I've also added TTT2 support for these addons:

https://github.com/gmod-workshop/ttt-timestop

https://github.com/gmod-workshop/ttt-laststand

TimGoll commented 3 years ago

Great! For the martyrdom: Please use my icon since we use a simple black/white icon: https://github.com/TTT-2/ttt_addon_graphics/blob/master/ICONS/icons_sidebar_64/item_hud_effect_martyrdom.png

and your laststanding has two colors whiich will look strange for bright hud colors because the color of the icon will be black

dhkatz commented 3 years ago

You want me to change the icon to be pure white for last stand?

TimGoll commented 3 years ago

It's your addon, do whatever you like :D It's just a recommendation from my side. I guess you have TTT2 installed? Go to the HUD Editor and set the HUD color to white, you'll see the "problem"

dhkatz commented 3 years ago

Yeah you were right. I took your advice and updated the icon for the ttt-martyrdom and ttt-laststand addons, already pushed to workshop

TimGoll commented 3 years ago

great, I'll take a look at them and then update the addonchecker

dhkatz commented 3 years ago

Thanks. Let me know if there's anything you think I should update

JoKrus commented 3 years ago

I can confirm for Clairvoyancy that it is functioning very well in TTT2, ConVar settings plus the addon itself

Attached Screenshot in game: https://media.discordapp.net/attachments/744888706338652170/788075205242519612/Screenshot_1.png?width=1202&height=676

TimGoll commented 3 years ago

@JoKrus Thanks! As soon as I start working on TTT2 again, I'll update the addonchecker.

dhkatz commented 3 years ago

Thank you everybody 😀