No Jester and Necromancer

[MiIkwater]

This change makes it so the Necromancer can't spawn in a round with the Jester. Rounds with both of these roles are very awkward, as the zombies and necromancer must be careful to not kill the jester, which is sometimes impossible. I've tested this a little bit and everything seems to be working fine.

[ThePlatinumGhost]

You should make a cvar because someone may disagree with you it is always better to give the choice Anyway an alternative can be that necro and zombie can see the jester

[TimGoll]

Something modular is planned for the future

[Histalek]

I dislike this as well. Firstly like PlatinumGhost already said, this should be configurable and not set in stone. Secondly you are not fixing the problem but are merely working around it. The real problem is that the zombies and the necromancer cannot see who the jester is, but they have to kill everyone but the jester.

So imo the solution should be either of the following:

• let the necromancer and zombies know/see who the jester is
• don't let the jester win if the necromancer or a zombie kills him

The latter approach is already possible with the TTT2PreventJesterWinstate hook.

on another note:

• you are messing with the roleselection behaviour from within a role, this could be highly confusing to serveradmins and players. Also this would mess with debugging roleselection problems
• what happens if the jester is not installed? there is no check for that so you would change the roleselection behaviour for no reason

[MiIkwater]

Thanks for the ideas everyone. I'll try and figure out the solutions you mentioned.

[MiIkwater]

I've messed around with it a ton and I can't get anything to work, so I think this can wait for the future.