TTUSDC / cpceed-webapp

CPCEED Web App
https://ttusdc.github.io/cpceed-webapp/
3 stars 0 forks source link

Packages and Linting #6

Closed NilsG-S closed 7 years ago

NilsG-S commented 7 years ago

Changes are as follows:

NilsG-S commented 7 years ago

So I'm pretty sure I know what's wrong. Basically the problem with the history module results from a conflict between grommet and react-router-dom. Both will install it, but installing grommet first means that it is submoduled under that package, rather than under react-router-dom, which doesn't like that.

EDIT:

I re-cloned the repository and the tests worked fine, so I'm inclined to believe this is an issue with Travis faulting on the re-installation order. Do you know of a way to have Travis install everything from scratch?

@asclines

EDIT2:

I could probably remove caching of node_modules from .travis.yml.

asclines commented 7 years ago

@NilsG-S continuing this conversation in Slack.

NilsG-S commented 7 years ago

@asclines So basically instead we're caching the place where NPM stores recently installed packages? That would have the same result of reducing build time (although to a lesser extent), while doing a fresh installation for each build.

asclines commented 7 years ago

The important part is that .npm doesn't store compiled native modules. That's what I believe caused the tests to constantly fail on the second version of node. Incompatible binaries were being cached.

NilsG-S commented 7 years ago

Sounds good, I'll go ahead and merge it