TTimo / GtkRadiant

The open source, cross platform level editor for idtech games
http://icculus.org/gtkradiant/
Other
591 stars 156 forks source link

Scons -j parameter is not defined #623

Open magicmyth opened 6 years ago

magicmyth commented 6 years ago

The scons build system quick help says we can define the number of build threads via the -jN switch but this is not implemented and when starting a build like the example:

scons -j8 --no-packs

A warning will be given:

scons: Reading SConscript files ...
syntax error (statement match): '-j8'
stop statement parse at '-j8'
...
TTimo commented 6 years ago

I think you need to pass parameters to scons in a different way. Maybe after a --.

magicmyth commented 6 years ago

I tried --j but that gives the same warning. I've just run it with only --no-packs and also get:

...
syntax error (statement match): '--no-packs'
stop statement parse at '--no-packs'
saving updated configuration
...

but that is definitely working (no packs downloaded) so it seems to be a false positive error. This happens both on Ubuntu 16.04 with scons 2.4 and in a Flatpak Builder environment that has scons 3.0.1. I don't know how to verify if the parallel threads switch actually works or not?

TTimo commented 6 years ago

--no-packs is an option for our scripts, -j if it works would be an option for scons.

magicmyth commented 6 years ago

I understand that. And I've just compared a build with and without the -j switch and the one with was much faster so its working. Just giving out errors about any switches even though they are valid.

ensiform commented 6 years ago

scons --no-packs -- -j8 ?

magicmyth commented 6 years ago

Still get a warning:

syntax error (statement match): '--no-packs'
stop statement parse at '--no-packs'