TTimo / GtkRadiant

The open source, cross platform level editor for idtech games
http://icculus.org/gtkradiant/
Other
591 stars 156 forks source link

Update SCons build scripts to build on Python 3 and Scons 3 #651

Closed yaspoon closed 4 years ago

yaspoon commented 4 years ago

Trying to build GtkRadiant on distributions that have made the switch to Python 3/Scons 3 such as Ubuntu 20.04 and ArchLinux would fail due to incompatibilities between Python 2.7 and 3.

The patchset does a few things: -Add parentheses to print calls -Change command.getstatusoutput to subprocess.check_output and adding some extra steps to make it work on both python 2.7 and 3 -Add build dependencies needed for Ubuntu 18.04, 20.04 and ArchLinux to the REAME.md

I've tested building and at least running these changes on ArchLinux, Ubuntu 18.04 and Ubuntu 20.04. Since Ubuntu 18.04 runs python 2.7 and Ubuntu 20.04 runs python 3 I would assume that it should work for most distributions of Linux.

TTimo commented 4 years ago

Looks good, thanks!