search

TTimo / GtkRadiant

The open source, cross platform level editor for idtech games
http://icculus.org/gtkradiant/
Other
581 stars 152 forks source link

q3map2: do not affect styled lightmaps by floodlight, fix #616 #652

Closed illwieckz closed 3 years ago

illwieckz commented 3 years ago

Fix issue introduced in #605 and reported by @Aciz in #616.

port of https://github.com/id-tech-3-tools/map-compiler/pull/12 https://github.com/id-tech-3-tools/map-compiler/commit/87b8589a3a5069c482243bb33c587fc18911746c

Sorry for the very long time without news. I basically lost motivation to work on NetRadiant / GtkRadiant q3map2 merge when I discovered that other fork requiring yet another “full time job” to merge, and when I discovered that other fork objectively reported the merge effort to others (even justifying this by taking example from the hard work I was doing on that Gtk/Net q3map2 merge). As my time is precious, I cannot let others decide on it.

Anyway, this fix was implemented by @Garux in that fork and I already merged it in NetRadiant upstream, so you may be happy to get it in GtkRadiant as well. @Aciz said “this patch is enough to solve the main issue”.

TTimo commented 3 years ago

Thanks, I'll take your word for it that this is correct.