search

TTimo / GtkRadiant

The open source, cross platform level editor for idtech games
http://icculus.org/gtkradiant/
Other
581 stars 152 forks source link

Adding support for OpenBSD/NetBSD #686

Closed bilaliscarioth closed 5 months ago

bilaliscarioth commented 1 year ago

Some errors from macro, config.py ( adding include dirs like /usr/X11R6/lib) other things like realpath which give an empty string for inexisting file. lock copy file

bilaliscarioth commented 1 year ago

Should replace defined(__FreeBSD__) || defined(__OpenBSD__) || defined(__NetBSD__) to defined(__BSD__) ?

bilaliscarioth commented 1 year ago

where should defined it on /libs/synapses.h?

kungfooman commented 1 year ago

This entire repo is just dead/unmaintained, right?

bilaliscarioth commented 1 year ago

I don't know if I should get it back my branch alive... but i didn't get any response where i could setup a macro as BSD inside GtkRadiant. (I would probably rewrite my ports, more correctly)

So if i can get any response for how i should replace FreeBSD || NetBSD || OpenBSD would be helpful !

TTimo commented 1 year ago

Having one macro for all the BSD flavors sounds fine. There were other concerns raised while reviewing this pull request that are arguably more important. Please update the pull request until all concerns are adressed and we'll merge it..

bilaliscarioth commented 1 year ago

TTimo can a use __unix__ macros or you prefer keeping__BSD__ ?

bilaliscarioth commented 1 year ago

Also as you can see Fix SIGTRAP/SIGILL commit, we need to change char into void against ROP on OpenBSD or undefined behaviours on other unix systems

TTimo commented 1 year ago

Seems like a __BSD__ macro would be appropriate in most cases.

bilaliscarioth commented 1 year ago

BSD macro ready !

bilaliscarioth commented 1 year ago

condition for avoiding issues from realpath workings well !

bilaliscarioth commented 1 year ago

up.

TTimo commented 1 year ago

Sorry this is still on my list to look at and integrate, I've just been too busy on other things to get to it.

TTimo commented 5 months ago

I rebased this and pushed it to https://github.com/TTimo/GtkRadiant/tree/bsd - I'm going to review it and clean it up some more, then merge it in. I will probably squash it all together into a single commit.

TTimo commented 5 months ago

This is now merged : https://github.com/TTimo/GtkRadiant/commit/b5dfbd485f312a09054245a1bb1f5716b8e5e78c Thank you for your patience with this!