TU-Berlin-DIMA / scotty-window-processor

This repository provides Scotty, a framework for efficient window aggregations for out-of-order Stream Processing.
https://tu-berlin-dima.github.io/scotty-window-processor/
Apache License 2.0
75 stars 23 forks source link

Possible bug or simple code duplication #12

Closed lawben closed 3 years ago

lawben commented 5 years ago

Not sure if this is a bug because I haven't come up with an actual example to test this, but in the StreamSlicer in determineSlice() there seems to be a small mistake in the code.

https://github.com/TU-Berlin-DIMA/scotty-window-processor/blob/a18a7dc101f814b41a416aca9785a5848221667d/slicing/src/main/java/de/tub/dima/scotty/slicing/StreamSlicer.java#L72-L77

As min_next_edge_ts == te, lines 74 and 76 are identical. I believe line 74 should add new Slice.Flexible(flex_count), as the flex_count ist > 0. If this is intended, the inner if-check can be removed.