TU-Wien-dataLAB / Grader-Labextension

BSD 3-Clause "New" or "Revised" License
3 stars 1 forks source link

UI Improvements Details grader_labextension release 0.3.0 #5

Closed mpetojevic closed 8 months ago

mpetojevic commented 11 months ago

UI Details - grader_labextension release 0.3.0

To improve the user experience in grader_labextension release 0.3.0, we want to implement the following details:

Update Currently File Tree for FilesList looks like this and is fully functional:

image

One thing that I would consider changing: Space between file icon and file name in the file list is much bigger than the space between folder icon and folder name. I discovered that it's because I added arrow icons for expanding/collapsing contents of the folder. These two icons take much more space than only the file icon. ListItemText has the same indentation for both folder and file name which are hierarchically the same, but this much of a difference in blank space might not be wanted. Only setting margins for the file name isn't helpful here. ListItemText and ListItemIcon currenty have the same settings for file and folder case.

Update Problems described above solved:

image

makeDirs(`${lectureBasePath}${lecture.code}`, [`create`, `${assignment.id}`, userDir])
meffmadd commented 11 months ago

I also need to update the extra files feature in the student file list. If the instructor checks the "Allow file upload by students" checkbox, the behavior should be disabled. I will work on this branch as well.

I merged dev into this branch to work on this issue.

meffmadd commented 11 months ago

I also had to fix a bug in the student file view (warnings) which required changes in the grader_service. We therefor also have to make a release of grader_service when releasing these changes!

meffmadd commented 10 months ago

Before we release we should also investigate TU-Wien-dataLAB/Grader-Labextension#4