TU-Wien-dataLAB / Grader-Service

Grader Service offers lecturers and students a well integrated teaching environment for data science, machine learning and programming classes.
https://grader-service.readthedocs.io/en/latest/
BSD 3-Clause "New" or "Revised" License
27 stars 2 forks source link

Autograding fails when convert tries to copy `extra_files` that were deleted #199

Closed meffmadd closed 5 months ago

meffmadd commented 5 months ago

Describe the bug Auto grading fails when a file that was added by an instructor (which is therefore part of extra_files), which was deleted in a submission. This only fails if the students cannot add files themselves.

The cause of this is probably a missing continue here: https://github.com/TU-Wien-dataLAB/Grader-Service/blob/6b2d9a1e9962c6487694857a4333c847d3711291/grader_service/grader_service/convert/converters/base.py#L291

To Reproduce Steps to reproduce the behavior:

  1. Delete a file in an assignment and submit
  2. Autograde submission
  3. Grading fails

Expected behavior The file should not be copied when they do not exists.