TUD-OS / NRE

NOVA runtime environment (official branch)
GNU General Public License v2.0
33 stars 12 forks source link

Speed up build by building morbo with the same scons instance as NRE #15

Closed Nils-TUD closed 11 years ago

Nils-TUD commented 11 years ago

I've just tested it. I don't know how you did it, but I had to change some things in morbos SConscript as well (e.g. include path) and had to add the freestanding_env to the SConstruct of NRE (although there would be other ways as well, of course). Which isn't really a problem (we could use a patch for morbo that does all that). But the speed-gain is not that much on my system. The build takes 2sec. with the change and 2.3sec without. Was the difference bigger for you?

Nils-TUD commented 11 years ago

Now I've checked out morbo again to get your changes. It does almost work. The only remaining problem seems to be that git describe is executed in nre and not in loader/morbo.

Nils-TUD commented 11 years ago

Oh. I didn't think of that. But it doesn't seem very problematic right now. Actually, it is nice to know if a particular morbo binary was built in the NRE tree. But it is hard to find that out from the SConscript file. I have to think about a good solution.

Btw, please keep the author name in the commit and the issue name in the commit msg. Otherwise, github is only half as useful. ;)