search

TUD-STKS / TargetOptimizer

TargetOptimizer
GNU General Public License v3.0
1 stars 0 forks source link

[Optimization Branch] Boundaries can be negative or NaN #14

Open paul-krug opened 4 years ago

paul-krug commented 4 years ago

Boundaries can be set to negative values or nan, when manipulating the boundary table. Nan is a bug for sure, but negative values might be a feature.

Simon-Stone commented 4 years ago

I agree, negative values make sense. Especially if there is no silence before the recording (i.e., the sample was taken from continuous speech).

paul-krug commented 4 years ago

Ok, so I will fix the NaN issue and will allow negative values.

Simon-Stone commented 4 years ago

Conceptually they make sense. But negative values will cause issues with the data export to gestural score files, which would be incompatible with VocalTractLab as of now. I'd say do not allow negative values for now, but keep it on the list of future improvements once we figure out how to deal with the related downstream issues.

paul-krug commented 4 years ago

Ok it is fixed. For now only positive numbers are allowed in the table. I will leave the issue open but changed the label from bug to feature request.