search

TUDelft-CITG / OpenCLSim

Rule driven scheduling of cyclic activities for in-depth comparison of alternative operating strategies.
https://openclsim.readthedocs.io
MIT License
14 stars 17 forks source link

Delivery Wibo critical path #109

Closed frank-klein-schaarsberg-wb closed 1 year ago

frank-klein-schaarsberg-wb commented 1 year ago

Hi @Pietervanhalem,

hierbij (met enige vertraging) de pull request van Wibo critical path. Ik zie dat de tests hier en daar falen (niet alleen bij de toegevoegde modules), dat lijkt te komen door een attribute error binnen flake8, niet in OpenCLSim. Graag aandacht daarvoor, de tests slagen lokaal immers wel.

Groet, Frank

review-notebook-app[bot] commented 1 year ago

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

frank-klein-schaarsberg-wb commented 1 year ago

  1. Can you make sure that the tests are working? (flake-8 > 4 is not stable. you can add flake8<4 to your test dependencies and then it should work again)

    1. can you make your branch up to date with the master?

    2. can you remove the Mocksim use case example with all its json files? We never really used it and it does not belong in the master.

All change requests should be fixed now.

SiggyF commented 1 year ago

This will be merged in separate commits.